Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECP-8486] Update quote totals and set tax included value in the express Apple Pay checkout #38

Merged
merged 10 commits into from
Aug 29, 2023
Merged

[ECP-8486] Update quote totals and set tax included value in the express Apple Pay checkout #38

merged 10 commits into from
Aug 29, 2023

Conversation

candemiralp
Copy link
Member

Summary

Express checkout includes tax amounts in the final amount with these changes. In addition to setting up the amount value, it calculates the quote totals with the selected shipping method or shipping address.

Tested scenarios

  • Complete a tax included/excluded payment with Apple Pay express

@candemiralp candemiralp requested a review from a team as a code owner July 17, 2023 12:16
@peterojo peterojo requested a review from a team as a code owner August 16, 2023 13:52
peterojo
peterojo previously approved these changes Aug 16, 2023
View reviewed changes
@candemiralp candemiralp requested a review from peterojo August 25, 2023 10:25
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 25, 2023 •
edited
Loading

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@candemiralp candemiralp merged commit cd0feee into develop Aug 29, 2023
@candemiralp candemiralp deleted the ECP-8486 branch August 29, 2023 08:46
@candemiralp candemiralp mentioned this pull request Aug 29, 2023
Open
@RokPopov RokPopov mentioned this pull request Sep 5, 2023
Merged
@candemiralp candemiralp added the Fix Indicates a bug fix label Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hossam-adyen hossam-adyen hossam-adyen approved these changes

@RokPopov RokPopov RokPopov approved these changes

@peterojo peterojo peterojo approved these changes

@khushboo-singhvi khushboo-singhvi Awaiting requested review from khushboo-singhvi khushboo-singhvi was automatically assigned from

@SushmitaThakur SushmitaThakur Awaiting requested review from SushmitaThakur SushmitaThakur was automatically assigned from

Assignees
No one assigned
Labels
Fix Indicates a bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@candemiralp @peterojo @RokPopov @hossam-adyen